Changeset 458

Timestamp:

01/11/07 19:15:55 (6 years ago)

Author:

max

Message:

Display failure messages in component stats

Location:

util

Files:

• server_daily_maint (modified) (4 diffs)
• server_daily_maint_component.tmpl (modified) (1 diff)

util/server_daily_maint

@@ -383 +383 @@
                                 $store->{total}->{'c_'.$c.'_runs'}++;
                                 $store->{per_hour}->[$hr_num]->{$g."_sysid_list"}->{$sid}++ if ($sid);
+                                if ($retcode =~ /(.*):(.*)/)
+                                {
+                                    my ($code, $msg) = ($1, $2);
+                                    my $shortsid = $1 if ($sid =~ /\d+\.(\d+)/);
+                                    unshift @{$store->{failcodes}->{$c}}, { timestamp => $starttime, sysid => $shortsid, file => $file, code => $code, msg => $msg };
+                                }
 
                                 # duration (total count, min, max, average from duration/counter)
@@ -535 +541 @@
         my $color = ($n < 75 ? "red" : $n < 90 ? "orange" : "lightgreen");
         return "<font color=\"$color\">$n%</font>";
+}
+
+sub report_failure_msgs
+{
+    my ($template, $c) = @_;
+
+    return unless $store->{failcodes}->{$c};
+
+    my @msgs;
+    for (my $i = 0; $i < @{$store->{failcodes}->{$c}}; $i++)
+    {
+        my %h = %{$store->{failcodes}->{$c}[$i]};
+
+        # Remove any entries older than 1 week
+        if ($h{timestamp} + 604800 < $starttime)
+        {
+            splice(@{$store->{failcodes}->{$c}}, $i);
+            last;
+        }
+        $h{timestamp} = strftime("%a %d %b %H:%M", localtime($h{timestamp}));
+        $h{msg} = '(no msg)' unless $h{msg};
+        push @msgs, { %h };
+    }
+
+    $template->param(FAILURE_MSGS => \@msgs);
 }
 
@@ -1016 +1047 @@
                 my @ret = report_count_data(0, 0, "c_".$c."_success_sysid_list", "all");
                 $h->{'COMPONENT_SUCCESS_RUNS'} = $ret[0];
-#               $h->{'COMPONENT_SUCCESS_RUNS_TOTAL'} = $ret[1];
                 @ret = report_count_data(0, 0, "c_".$c."_fail_sysid_list", "all", "ignore-zero");
                 $h->{'COMPONENT_FAIL_RUNS'} = $ret[0];
-#               $h->{'COMPONENT_FAIL_RUNS_TOTAL'} = $ret[1];
 
                 $h->{'SUCCESS_RATE_WEEK'} = calc_success_rate($c, "week");
@@ -1051 +1080 @@
                 $template->param('NAME', $c);
 
-                 &report_count_data($template, 'SUCCESS', 'c_'.$c.'_success_sysid_list', 'all');
-                 &report_count_data($template, 'MISSING', 'c_'.$c.'_missing_sysid_list', 'all');
-                 &report_count_data($template, 'FAILURE', 'c_'.$c.'_fail_sysid_list', 'all');
-                 &graph_count_data($template, 'GRAPHS_USAGE', 'day week 12week year', 0, 'c_'.$c.'_success_sysid_list', 'c_'.$c.'_missing_sysid_list', 'c_'.$c.'_fail_sysid_list');
+                &report_count_data($template, 'SUCCESS', 'c_'.$c.'_success_sysid_list', 'all');
+                &report_count_data($template, 'MISSING', 'c_'.$c.'_missing_sysid_list', 'all');
+                &report_count_data($template, 'FAILURE', 'c_'.$c.'_fail_sysid_list', 'all');
+                &graph_count_data($template, 'GRAPHS_USAGE', 'day week 12week year', 0, 'c_'.$c.'_success_sysid_list', 'c_'.$c.'_missing_sysid_list', 'c_'.$c.'_fail_sysid_list');
 
                 &report_count_data($template, 'RUNS_SEEN', 'c_'.$c.'_runs', "all");
                 &graph_count_data($template, 'GRAPHS_RUNS', "day week 12week year", 0, 'c_'.$c.'_runs');
+
+                &report_failure_msgs($template, $c);
 
                 my @sf; 

util/server_daily_maint_component.tmpl

@@ -32 +32 @@
 <TMPL_LOOP NAME=GRAPHS_MISSING>
  <br><TMPL_VAR NAME=GRAPH>
+</TMPL_LOOP>
+</td></tr>
+
+<tr><td align=left valign=top nowrap colspan=2>
+<h2>Failures</h2>
+<p>Output from recent failures</p>
+<TMPL_LOOP NAME=FAILURE_MSGS>
+ <li><a href="/dev/stats/<TMPL_VAR NAME=FILE>.done"><TMPL_VAR NAME=TIMESTAMP></a> [<TMPL_VAR NAME=SYSID>]: <b><TMPL_VAR NAME=CODE></b>: <TMPL_VAR NAME=MSG></li>
 </TMPL_LOOP>
 </td></tr>